Skip to content

Conversation

@artur-oracle
Copy link
Member

@artur-oracle artur-oracle commented Oct 23, 2025

For the signatureSchemes we return only what's been set by the user, the default values are not being returned like for other SSLParameters.
Also enhancing "java -XshowSettings:security:tls" option to show the enabled signature schemes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366364: Return enabled signature schemes with SSLConfiguration#getSSLParameters() call (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27961/head:pull/27961
$ git checkout pull/27961

Update a local copy of the PR:
$ git checkout pull/27961
$ git pull https://git.openjdk.org/jdk.git pull/27961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27961

View PR using the GUI difftool:
$ git pr show -t 27961

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27961.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2025

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@artur-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366364: Return enabled signature schemes with SSLConfiguration#getSSLParameters() call

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 23, 2025

@artur-oracle The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2025

@AlanBateman
Copy link
Contributor

/label remove core-libs
/label remove hotspot-runtime

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@AlanBateman
The core-libs label was successfully removed.

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

@AlanBateman
The hotspot-runtime label was successfully removed.

@seanjmullan
Copy link
Member

In the JBS issue, can you also add that you are enhancing java -XshowSettings:security:tls to show the enabled signature schemes?

- Remove now unnecessary null check for config.signatureSchemes
@artur-oracle artur-oracle changed the title 8366364: Address inconsistencies in SSLParameters object returned by SSLConfiguration#getSSLParameters() call 8366364: Return enabled signature schemes with SSLConfiguration#getSSLParameters() call Oct 29, 2025
Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add a release note.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 31, 2025
@artur-oracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 3, 2025

Going to push as commit 02a7217.
Since your change was applied there have been 70 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 3, 2025
@openjdk openjdk bot closed this Nov 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 3, 2025
@openjdk
Copy link

openjdk bot commented Nov 3, 2025

@artur-oracle Pushed as commit 02a7217.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security [email protected]

Development

Successfully merging this pull request may close these issues.

5 participants